1032: Diff currently unavailable when viewing diffs of diffs

mw.t****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
May 9, 2009 
What steps will reproduce the problem?
1. Post a review request with changes to multiple files
2. Change some, but not all of said files
3. Upload an updated diff
4. View the changes between the first and second set of diffs

What is the expected output?
Files that have not changed are either clearly marked as such or omitted
from the output.

What do you see instead?
"Diff currently unavailable" error for files that did not change between
the two diff sets.

What operating system are you using? What browser?
RB 1.0b2 on Linux. Using Firefox.
#1 sebastie*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
I have the same issue.
chipx86
#2 chipx86 
This shouldn't be happening anymore. Can you try a nightly and see if you're still
hitting this? It's important for us to know soon for beta 1.

Can you get a very simple repro case? Ideally post something to demo.review-board.org
that I can test against.
  • +NeedInfo
  • +Milestone-Release1.0
    +Interdiffs
    +Component-DiffViewer
  • +chipx86
chipx86
#3 chipx86 
Assuming it's fixed. Make sure to also clear your server cache. Please reopen if this
still happens.
  • -NeedInfo
    +Fixed
#4 dby****@musicians********** (Google Code) (Is this you? Claim this profile.) 
this is happening for me with ReviewBoard-1.0rc2.dev_20090506-py2.4.egg

server running on CentOS 5 with mod_python under apache 2.2

client opensuse 10.2 running Firefox 2.0.0.17
chipx86
#5 chipx86 
Can you provide a set of diffs that work as a repro case for this?
  • -Fixed
    +NeedInfo
#6 dby****@musicians********** (Google Code) (Is this you? Claim this profile.) 
The error appears on http://subversion-test/reviews/r/14/diff/1-2/#index_header

NOTE: 
Diff 1 changes both file1.txt and file2.txt
Diff 2 changes file1.txt but does not change file2.txt (relative to Diff 1)
  • +
    bug-1.patch 
    Index: /reviewboard-issue-1032-example/branches/1/file1.txt
    ===================================================================
    --- /reviewboard-issue-1032-example/branches/1/file1.txt	(revision 0)
    +++ /reviewboard-issue-1032-example/branches/1/file1.txt	(revision 38)
    @@ -0,0 +1 @@
    +this is file 1
    Property changes on: file1.txt
    ___________________________________________________________________
    Added: svn:eol-style
       + native
    Added: svn:mime-type
       + text/plain
    Added: svn:keywords
       + Date Author Id Revision HeadURL
    Index: /reviewboard-issue-1032-example/branches/1/file2.txt
    ===================================================================
    --- /reviewboard-issue-1032-example/branches/1/file2.txt	(revision 0)
    +++ /reviewboard-issue-1032-example/branches/1/file2.txt	(revision 38)
    @@ -0,0 +1 @@
    +this is file 2
    Property changes on: file2.txt
    ___________________________________________________________________
    Added: svn:eol-style
       + native
    Added: svn:mime-type
       + text/plain
    Adde
    
 
    

    


    +


    
 
    
  bug-2.patch
  
    

  
    
 
    

 
    
  
     
    Index: /reviewboard-issue-1032-example/branches/1/file1.txt
    ===================================================================
    --- /reviewboard-issue-1032-example/branches/1/file1.txt	(revision 0)
    +++ /reviewboard-issue-1032-example/branches/1/file1.txt	(revision 40)
    @@ -0,0 +1 @@
    +this is file one
    Property changes on: file1.txt
    ___________________________________________________________________
    Added: svn:eol-style
       + native
    Added: svn:mime-type
       + text/plain
    Added: svn:keywords
       + Date Author Id Revision HeadURL
    Property changes on: .
    ___________________________________________________________________
    Added: mfreviewboard:startrev
       + 37
    Added: mfreviewboard:reviewid
       + 14
    Index: /reviewboard-issue-1032-example/branches/1/file2.txt
    ===================================================================
    --- /reviewboard-issue-1032-example/branches/1/file2.txt	(revision 0)
    +++ /reviewboard-issue-1032-example/branches/1/file2.txt	(revision 40)
    @@ -0,0 +1 @@
    +this is file 2
    Pr
    
 
    

    


    
   
    • 


  


 








 

  

   chipx86

  

 
 

  

    
     

   
   #7
   chipx86


  


  
Your patches don't cause this to repro for me. It works perfectly fine here.

Can you upload something to demo.review-board.org against the Review Board codebase
that demonstrates this?



 








 

   

 
 

  

    
     

   
   #8
   dby****@musicians********** (Google Code)



(Is this you? Claim this profile.)


  


  
http://demo.review-board.org/r/1767/diff/1-2/#index_header

Note that the interdiff for file2.txt shows

Diff currently unavailable.
Error: Internal error. Unable to locate file record for filediff 1975

I would expect either no frame displayed for file2.txt (this would be my preference),
or a message like "no changes made in file2.txt", or a blank frame



 








 

  

   chipx86

  

 
 

  

    
     

   
   #9
   chipx86


  


  
The reason for this is that we filter out unchanged diffs when displaying interdiffs,
but only when loading fragments. So up-front, we think we have this one, but then we
don't return anything when we load the fragment since it didn't change, hence the
error about not finding the fragment.



 








 

  

   chipx86

  

 
 

  

    
     

   
   #10
   chipx86


  


  
Fixed in r1968.



  
    


   
  • 
    
    
    -NeedInfo
    +Fixed
    
   
    • 


  


 








 

   

 
 

  

    
     

   
   #11
   yim****@gmai***** (Google Code)



(Is this you? Claim this profile.)


  


  
Unfortunately this happened on me for now.
http://ramble.corp.good.com/reviewboard/r/12744/diff/
Please let me know how to clear server cache for me.