1031: Keyboard shortcut only compatible with QWERTY keyboard

sebastie*********@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
April 19, 2009 
Hello,

Our french developper team is going to use RB, but the shorcuts [ and ] for 
privous and next comments are not working on a FR keyboard (I assume it's 
because "[" = "AltGr + (" and "]" = "AltGr + )" on a french keyboard).

I added in /var/www/reviewboard/htdocs/media/rb/js/diffviewer.js the keys 
"x" and "c" for previous and next comment, but I have two problem :
- What will happen when I will have to do a easy_install -U ReviewBoard 
followed by a rb-site upgrade ? Will my change in the code overwritten ?
- I guess it would be nice to allow a personalisation of these shortcuts in 
the admin dashboard.

Thank you very much for the good work !
chipx86
#1 chipx86 
We can make that change in Review Board.
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Usability
    +EasyFix
    +Keyboard
    +Milestone-Release1.0
    +Component-DiffViewer
chipx86
#2 chipx86 
Added "x" and "c" keyboard shortcuts. Committed in r1909.
  • -Confirmed
    +Fixed
  • +chipx86
#3 sebastie*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Great, thank you very much !