3213: rbtools git client fails if core.bare is unset

nan****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 28, 2014 
What version are you running?
rbtools 0.5.1

What's the URL of the page containing the problem?
NA

What steps will reproduce the problem?
1. repo sync or git clone a git repo
2. core.bare is not set in .git/config
3. post-review

What is the expected output? What do you see instead?
post-review fails because git config core.bare exit 1 and exception is not caught
if git config core.bare exit 1 it means core.bare != true

What operating system are you using? What browser?
NA

Please provide any additional information below.
#1 nan****@gmai***** (Google Code) (Is this you? Claim this profile.) 
when using git-repo tool without mirroring support (to be confirmed), git clones are setup without core.bare set.
#2 nan****@gmai***** (Google Code) (Is this you? Claim this profile.) 
A proposal to fix this issue at
https://reviews.reviewboard.org/r/5342
david
#3 david 
Fixed in rbtools master (6a44356). Thanks!
  • +Fixed
#4 nan****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Hi David,

could you please cherry-pick 6a44356 to release-0.6.x so that it could be included in next 0.6.3 release?

Regards

Nicolas
david
#5 david 
This commit was made before we created the release-0.6.x branch (from master), so it's included in all 0.6.x releases.
#6 nan****@gmai***** (Google Code) (Is this you? Claim this profile.) 
damned, you're right :-(

sorry for this noise