3197: rbt post requires summary and description for existing changenum (perforce)

jaab****@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
Jan. 17, 2014 
What version are you running?
RBTools 0.5.5/Review Board 1.7.20

What's the URL of the page containing the problem?
RBTools defect only

What steps will reproduce the problem?
1. Create a new review request and publish.
rbt post -p --target-people=person 496863

2. Edit the existing review request and publish.
 rbt post -p 496863
ERROR:root:Error updating review request draft: One or more fields had errors (HTTP 400, API Error 105)

    changenum: Field is not supported

3. Try adding -u.
rbt post -p -u 496863
ERROR:root:--summary and --description are required.

4. Add summary and description.
rbt post -p -u --summary "post-review..." --description "...didn't need this" 496863
Update Review Request #39: 'bug: none Testing rbt'?  [Yes/No]: yes
Review request #39 posted.

https://reviewboard.some.domain/r/39/

What is the expected output? What do you see instead?
Today, our developers use a single command alias with post-review to accomplish this task and expect the command from item 2 to work like it does with post-review.

What operating system are you using? What browser?
OS X 10.8.5/Python 2.7.2

Please provide any additional information below.
david
#1 david 
Is this with a submitted changelist or a pending changelist?
  • +NeedInfo
#2 jaab****@gmai***** (Google Code) (Is this you? Claim this profile.) 
My example was with a pending changelist although I have noticed the same behavior with a submitted changelist. Having this work with pending is more critical.
david
#3 david 
OK, that is definitely incorrect. I'll look into this ASAP.
david
#4 david 
Can you re-run your commands with --debug and include the output in this report?
david
#5 david 
OK, I've figured out what's going on here. I'll have a change up for review shortly.
  • -NeedInfo
    +PendingReview
  • +Component-RBTools
  • +david
david
#6 david 
Fixed in rbtools release-0.5.x (3f2e135). This will ship with 0.5.6

In the meantime, I suggest doing the update without the publish:

$ rbt post -o 496863

and then hitting "Publish" in the web UI.
  • -PendingReview
    +Fixed
#7 jaab****@gmai***** (Google Code) (Is this you? Claim this profile.) 
We have patched our 0.5.5 RBTools with the fix and the post command now works as expected. We appreciate your quick response and resolution!

Jason Bryan
Lead Engineer, Continuous Product Development
Zimbra, Inc.