2568: post-review (Perforce) does not work with Perforce brokers

je**@jeffmar******** (Google Code) (Is this you? Claim this profile.)
Dec. 9, 2013 
What version are you running?
2.6


What's the URL of the page containing the problem?
post-review (command line)

What steps will reproduce the problem?
1. Attempt to do a post-review with a Perforce broker/server setup
2.
3.



What is the expected output? What do you see instead?
It is choosing the server instead of the broker

What operating system are you using? What browser?
Linux

Please provide any additional information below.
. In lib/python2.6/site-packages/RBTools-0.4.1-py2.6.egg/rbtools/clients/perforce.py, I made the following change:

From (around line 33):
        m = re.search(r'^Server address: (.+)$', data, re.M)
        if not m:
           return None
To:
        m = re.search(r'^Broker address: (.+)$', data, re.M)
        if not m:
            m = re.search(r'^Server address: (.+)$', data, re.M)
            if not m:
                return None
david
#1 david
  • +Component-RBTools
#2 rich*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Same issue exists on windows.
#3 je**@jeffmar******** (Google Code) (Is this you? Claim this profile.) 
It's a simple and safe change to perforce.py … 

If you guys could make this change, it would sure help us adopt
new versions more easily.

BTW, it works on Windows as well :-)
david
#4 david 
We need patches to be submitted to https://reviews.reviewboard.org/
#5 je**@jeffmar******** (Google Code) (Is this you? Claim this profile.) 
Did so .. it's : https://reviews.reviewboard.org/r/5062/
david
#6 david 
Pushed to rbtools release-0.5.x (3a78ad0). Thanks!
  • +Fixed