1852: postreview doesn't respect files passed in for --revision-range

lamo*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 6, 2010
What version are you running?
RBTools 0.2

What's the URL of the page containing the problem?
post-review --revision-range 1.1:1.2 file1.c

What steps will reproduce the problem?
1. post-review with --revision-range using CVS
2.
3.

What is the expected output? What do you see instead?
Creates a Review Request.

What operating system are you using? What browser?


Please provide any additional information below.

diff --git a/rbtools/postreview.py b/rbtools/postreview.py
index dee2ccf..c85b021 100755
--- a/rbtools/postreview.py
+++ b/rbtools/postreview.py
@@ -802,7 +802,7 @@ class CVSClient(SCMClient):
         for rev in revision_range.split(":"):
             revs += ["-r", rev]
 
-        return self.do_diff(revs)
+        return self.do_diff(revs + args)
 
     def do_diff(self, params):
         """
david
#1 david
  • +Component-RBTools
david
#2 david
Fixed in rbtools 0f1569d. Thanks!
  • +Fixed