1191: post-review with no arguments generated an empty review request

jameslin
Nov. 7, 2010 
What version are you running?
chipx86 says 1.0RC3.

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. I ran post-review with no arguments expecting to see command-line help.
2. post-review generated a lot of error spew.
3. Awhile later, I look at my outgoing review requests, and I saw an empty
one (no summary/description/dif).

What is the expected output? What do you see instead?
It'd be nice if post-review with no arguments printed command-line help
instead, I think. (Unless it's supposed to generate a diff for files in the
'default' changeset?)

What operating system are you using? What browser?
Red Hat 9

Please provide any additional information below.
chipx86
#1 chipx86 
I'm not seeing this when I run it. Can you still repro this? What error spew do you see?

Running post-review without arguments is actually the standard way of using it
outside of Perforce, since most SCMs don't have changesets. We're getting default
changeset support in post-review, but I don't know for sure if running without
arguments will use "default" or not.
  • +NeedInfo
#2 jameslin 
Yup, I can still reproduce it.  The error spew seems to have been greatly reduced
(I don't remember what it was before; I should have saved it.  Oops.)

What I get now is:

   Error uploading diff: One or more fields had errors (105)
   Your review request still exists, but the diff is not attached.

This happens regardless of whether I have any files open for edit or not.
david
#3 david
  • -NeedInfo
    +Confirmed
#4 jameslin 
BTW, similar stuff happens if I make a typo in the Perforce change number and no such
changeset exists.
david
#5 david
  • +Component-RBTools
#6 ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I have a review out to fix this: http://reviews.reviewboard.org/r/1886/
david
#7 david
  • -Confirmed
    +Fixed